Skip to content

Workflow improvements#9609

Merged
RobinMalfait merged 6 commits intomasterfrom
fix/workflow-improvements
Oct 20, 2022
Merged

Workflow improvements#9609
RobinMalfait merged 6 commits intomasterfrom
fix/workflow-improvements

Conversation

@RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Oct 19, 2022

This PR adds a few workflow improvements.

  • Dropped download links for the draft release (GitHub already adds them)
  • Separate test and lint
  • Create dedicated lint job (so that it only executes once)
  • Drop the pretier-plugin-tailwindcss for now
  • Our plugin is awesome, but it always runs an older version of Tailwind CSS (the one it is coupled with). If Tailwind is a dependency it will use that version instead. However we can't rely on that because the node/npm versions we use don't support that well. Meaning, the moment we drop support for those old versions we will add it immediately.

GitHub already shows them in a table right below it.
Which means that we don't need to do the crazy linking in certain
workflows.
The `lint` tests will run against source files and should not be
dependant on a specific node version. Instead of running the `npm run
style` on every node version we use, we can and should only run it once.
As long as we use older versions of node/npm where we can't have
ourselves as a dependency, it is a bit of a mess to maintain properly
sorted html in tests.

Let's remove it for now until we have a better solution!
@RobinMalfait RobinMalfait force-pushed the fix/workflow-improvements branch from cb55a16 to e8ad7d3 Compare October 20, 2022 16:02
@RobinMalfait RobinMalfait changed the title [WIP] Workflow improvements Workflow improvements Oct 20, 2022
@RobinMalfait RobinMalfait merged commit 3c7fc69 into master Oct 20, 2022
@RobinMalfait RobinMalfait deleted the fix/workflow-improvements branch October 20, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments